Branch: refs/heads/main
Home: https://github.com/OpenAMP/open-amp
Commit: 04a4185d795dc1ddd3a23038579f799fe3940d1b
https://github.com/OpenAMP/open-amp/commit/04a4185d795dc1ddd3a23038579f799f…
Author: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Date: 2024-06-28 (Fri, 28 Jun 2024)
Changed paths:
M lib/include/openamp/virtio.h
Log Message:
-----------
lib: virtio: fix zephyr build warning
Building the samples/subsys/ipc/openamp_rsc_table/ sample generates the
following warning:
[24/182] Building C object zephyr/CMakeFiles/zephyr.dir/lib/open-amp/resource_table.c.obj
In file included from /zephyrproject/zephyr/lib/open-amp/./resource_table.h:11,
from /zephyrproject/zephyr/lib/open-amp/resource_table.c:30:
/zephyrproject/modules/lib/open-amp/open-amp/lib/include/openamp/virtio.h:83:2:
warning: #warning "VIRTIO_DRIVER_SUPPORT and/or VIRTIO_DEVICE_SUPPORT should be defined" [-Wcpp]
83 | #warning "VIRTIO_DRIVER_SUPPORT and/or VIRTIO_DEVICE_SUPPORT should be defined"
| ^~~~~~~
The issue occurs because the project includes the virtio API while
VIRTIO_DRIVER_SUPPORT and VIRTIO_DEVICE_SUPPORT is only defined for
the open-amp library build.
Fix the warning by testing deprecated usage of VIRTIO_DRIVER_ONLY and
VIRTIO_DEVICE_ONLY but not under
#if !defined(VIRTIO_DRIVER_SUPPORT) && !defined(VIRTIO_DEVICE_SUPPORT)
condition.
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Commit: b7cadeb7ce7631a7ac476ed4be0440a551c002f5
https://github.com/OpenAMP/open-amp/commit/b7cadeb7ce7631a7ac476ed4be0440a5…
Author: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Date: 2024-06-28 (Fri, 28 Jun 2024)
Changed paths:
M lib/include/openamp/virtio.h
Log Message:
-----------
lib: virtio: Rework macros VIRTIO_ROLE_IS_DEVICE and VIRTIO_ROLE_IS_DRIVER
The virtio.h header can be included by applications. In such cases,
VIRTIO_DRIVER_SUPPORT and VIRTIO_DEVICE_SUPPORT, which are used to
optimize the library, may not be defined in the application.
Define default VIRTIO_ROLE_IS_DEVICE and VIRTIO_ROLE_IS_DRIVER macros
that do not check for VIRTIO_DEVICE_SUPPORT or VIRTIO_DRIVER_SUPPORT if
they are not defined.
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Commit: f2f66453495a06e38045d7c2ac7e71c65ab68a1d
https://github.com/OpenAMP/open-amp/commit/f2f66453495a06e38045d7c2ac7e71c6…
Author: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Date: 2024-06-28 (Fri, 28 Jun 2024)
Changed paths:
M lib/rpmsg/rpmsg.c
Log Message:
-----------
lib: rpmsg: Pass endpoint private data during registration
This patch fixes the rpmsg_create_ept function passing the endpoint's private
data that can be set by the application before the call of
rpmsg_create_ept.
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Commit: 856680eb99cee67dfff3d2e9c6d4ede3b7549895
https://github.com/OpenAMP/open-amp/commit/856680eb99cee67dfff3d2e9c6d4ede3…
Author: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Date: 2024-06-28 (Fri, 28 Jun 2024)
Changed paths:
M VERSION
Log Message:
-----------
release: open-amp 2024.05.1
Set library version to 1.6.1
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Compare: https://github.com/OpenAMP/open-amp/compare/e9eef7ce57c3...856680eb99ce
To unsubscribe from these emails, change your notification settings at https://github.com/OpenAMP/open-amp/settings/notifications
Branch: refs/heads/v2024.05
Home: https://github.com/OpenAMP/open-amp
Commit: 04a4185d795dc1ddd3a23038579f799fe3940d1b
https://github.com/OpenAMP/open-amp/commit/04a4185d795dc1ddd3a23038579f799f…
Author: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Date: 2024-06-28 (Fri, 28 Jun 2024)
Changed paths:
M lib/include/openamp/virtio.h
Log Message:
-----------
lib: virtio: fix zephyr build warning
Building the samples/subsys/ipc/openamp_rsc_table/ sample generates the
following warning:
[24/182] Building C object zephyr/CMakeFiles/zephyr.dir/lib/open-amp/resource_table.c.obj
In file included from /zephyrproject/zephyr/lib/open-amp/./resource_table.h:11,
from /zephyrproject/zephyr/lib/open-amp/resource_table.c:30:
/zephyrproject/modules/lib/open-amp/open-amp/lib/include/openamp/virtio.h:83:2:
warning: #warning "VIRTIO_DRIVER_SUPPORT and/or VIRTIO_DEVICE_SUPPORT should be defined" [-Wcpp]
83 | #warning "VIRTIO_DRIVER_SUPPORT and/or VIRTIO_DEVICE_SUPPORT should be defined"
| ^~~~~~~
The issue occurs because the project includes the virtio API while
VIRTIO_DRIVER_SUPPORT and VIRTIO_DEVICE_SUPPORT is only defined for
the open-amp library build.
Fix the warning by testing deprecated usage of VIRTIO_DRIVER_ONLY and
VIRTIO_DEVICE_ONLY but not under
#if !defined(VIRTIO_DRIVER_SUPPORT) && !defined(VIRTIO_DEVICE_SUPPORT)
condition.
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Commit: b7cadeb7ce7631a7ac476ed4be0440a551c002f5
https://github.com/OpenAMP/open-amp/commit/b7cadeb7ce7631a7ac476ed4be0440a5…
Author: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Date: 2024-06-28 (Fri, 28 Jun 2024)
Changed paths:
M lib/include/openamp/virtio.h
Log Message:
-----------
lib: virtio: Rework macros VIRTIO_ROLE_IS_DEVICE and VIRTIO_ROLE_IS_DRIVER
The virtio.h header can be included by applications. In such cases,
VIRTIO_DRIVER_SUPPORT and VIRTIO_DEVICE_SUPPORT, which are used to
optimize the library, may not be defined in the application.
Define default VIRTIO_ROLE_IS_DEVICE and VIRTIO_ROLE_IS_DRIVER macros
that do not check for VIRTIO_DEVICE_SUPPORT or VIRTIO_DRIVER_SUPPORT if
they are not defined.
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Commit: f2f66453495a06e38045d7c2ac7e71c65ab68a1d
https://github.com/OpenAMP/open-amp/commit/f2f66453495a06e38045d7c2ac7e71c6…
Author: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Date: 2024-06-28 (Fri, 28 Jun 2024)
Changed paths:
M lib/rpmsg/rpmsg.c
Log Message:
-----------
lib: rpmsg: Pass endpoint private data during registration
This patch fixes the rpmsg_create_ept function passing the endpoint's private
data that can be set by the application before the call of
rpmsg_create_ept.
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Commit: 856680eb99cee67dfff3d2e9c6d4ede3b7549895
https://github.com/OpenAMP/open-amp/commit/856680eb99cee67dfff3d2e9c6d4ede3…
Author: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Date: 2024-06-28 (Fri, 28 Jun 2024)
Changed paths:
M VERSION
Log Message:
-----------
release: open-amp 2024.05.1
Set library version to 1.6.1
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Compare: https://github.com/OpenAMP/open-amp/compare/e9eef7ce57c3...856680eb99ce
To unsubscribe from these emails, change your notification settings at https://github.com/OpenAMP/open-amp/settings/notifications
Branch: refs/heads/unbind_rpmsg_dev
Home: https://github.com/OpenAMP/openamp-system-reference
Commit: a5dd6735f0961e1b0311d93c93a6e79d389de727
https://github.com/OpenAMP/openamp-system-reference/commit/a5dd6735f0961e1b…
Author: Tanmay Shah <tanmay.shah(a)amd.com>
Date: 2024-06-27 (Thu, 27 Jun 2024)
Changed paths:
M examples/linux/common/common.c
M examples/linux/common/common.h
M examples/linux/rpmsg-echo-test/echo_test.c
M examples/linux/rpmsg-mat-mul/mat_mul_demo.c
M examples/linux/rpmsg-proxy-app/proxy_app.c
Log Message:
-----------
examples: linux: unbind rpmsg device
RPMsg linux app should unbind rpmsg device from char driver once
communication is done. Without unbind, rpmsg app can't bind same
device with rpmsg char driver again.
Signed-off-by: Tanmay Shah <tanmay.shah(a)amd.com>
To unsubscribe from these emails, change your notification settings at https://github.com/OpenAMP/openamp-system-reference/settings/notifications
Branch: refs/heads/unbind_rpmsg_dev
Home: https://github.com/OpenAMP/openamp-system-reference
Commit: aec2a40d94df2bde4660c9d995ccca096e7ec92b
https://github.com/OpenAMP/openamp-system-reference/commit/aec2a40d94df2bde…
Author: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Date: 2024-05-20 (Mon, 20 May 2024)
Changed paths:
M west.yml
Log Message:
-----------
west: update to zephyr 3.6
Update to the last Zephyr release
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Commit: 132e8a4b5f8e9b2fae753c42011d9384ae843898
https://github.com/OpenAMP/openamp-system-reference/commit/132e8a4b5f8e9b2f…
Author: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Date: 2024-05-20 (Mon, 20 May 2024)
Changed paths:
M west.yml
Log Message:
-----------
west: update to openamp and libmetal v2024.05
Update to the last openamp and libmetal versions
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Commit: a364e30755000a3cd585cf625bb73c65c5155fb3
https://github.com/OpenAMP/openamp-system-reference/commit/a364e30755000a3c…
Author: Tanmay Shah <tanmay.shah(a)amd.com>
Date: 2024-06-27 (Thu, 27 Jun 2024)
Changed paths:
M examples/linux/common/common.c
M examples/linux/common/common.h
M examples/linux/rpmsg-echo-test/echo_test.c
M examples/linux/rpmsg-mat-mul/mat_mul_demo.c
M examples/linux/rpmsg-proxy-app/proxy_app.c
Log Message:
-----------
examples: linux: unbind rpmsg device
RPMsg linux app should unbind rpmsg device from char driver once
communication is done. Without unbind, rpmsg app can't bind same
device with rpmsg char driver again.
Signed-off-by: Tanmay Shah <tanmay.shah(a)amd.com>
Compare: https://github.com/OpenAMP/openamp-system-reference/compare/aec2a40d94df%5E…
To unsubscribe from these emails, change your notification settings at https://github.com/OpenAMP/openamp-system-reference/settings/notifications
________________________________
Von: Tanmay Shah <tanmay.shah(a)amd.com>
Gesendet: Donnerstag, 6. Juni 2024 17:44
An: Andreas Pankoke <APankoke(a)comprion.com>
Betreff: Re: AW: [Openamp-rp] c++ in xlinx linux
Hello,
On 6/6/24 10:24 AM, Andreas Pankoke wrote:
> Hello,
> thanks for your reply.
>
> Are you trying to load R5 firmware written in C++ from Linux kernel?
> Or R5 firmware for one core in C++ is getting loaded from another R5 core in split mode?
>
> No. Iam loading the R5 Program via OpenAMP from the Linux Kernel in R5_0 like this. The R5 should be running in split-Mode. This is configured via the Device-tree:
>
> echo CLWaveNFC_Test02.elf > /sys/class/remoteproc/remoteproc0/firmware
> echo start > state
>
If you are executing these steps, then OpenAMP loader isn't used at all if I understand correctly.
Instead it's elf loader in linux kernel.
Here: https://github.com/torvalds/linux/blob/v6.10-rc2/drivers/remoteproc/remotep…
As of now, on Xilinx platform C++ loading isn't tested.
Thanks.
Yes this one is failing I think.
BR
Andreas
> The Program has been written in C++.
>
> "these things" could you please explain specifics?
>
> Were working on the Xilinx branch.
> I mean the fix in the OpenAMP branch regarding the fix:
> #27
> https://github.com/OpenAMP/open-amp/issues/27
>
> I would like to know, if it is possible to get this, c++ loading, running on the Xilinx side.
>
> Xilinx's Petalinux releases usually rely on upstream OpenAMP and Libmetal library releases.
> As of now once changes are merged in upstream OpenAMP and Libmetal libraries,
> they are picked up in .1 release cycle of Petalinux.
>
> I get the error with every Release of petalinux I've tested (2021.2 & 2024.1)
>
> the error(s) is(are) essentially the following:
> [ 801.017356][ T1162] remoteproc remoteproc0: trace0 added: da 0x3ee00220, len 0x1000
> [ 801.027989][ T1162] remoteproc remoteproc0: bad phdr da 0x0 mem 0x19680
> [ 801.034608][ T1162] remoteproc remoteproc0: Failed to load program segments: -22
> [ 801.047128][ T1162] remoteproc remoteproc0: Boot failed: -22
>
> BR
> Andreas
>
>
>
> ________________________________
> Von: Tanmay Shah <tanmay.shah(a)amd.com>
> Gesendet: Donnerstag, 6. Juni 2024 16:32
> An: Andreas Pankoke <APankoke(a)comprion.com>; openamp-rp(a)lists.openampproject.org <openamp-rp(a)lists.openampproject.org>
> Betreff: Re: [Openamp-rp] c++ in xlinx linux
>
> Hello,
>
> I would like you understand your use case first.
> Please find my questions inline.
>
>
> On 6/6/24 8:29 AM, Andreas Pankoke via Openamp-rp wrote:
>> We are COMPRION GmbH from Germany, and we are using the Xilinx FPGA
>> ZynqMP XCZU3EG for our new testing-devices.
>>
>> I'am an embedded engineer, with the responsibillity to program the
>> ZynqMP Linux and R5 Progs.
>>
>> Currently I've the problem, that a load of a c++ program via remoteproc
>> doesnot work in the xilinx petalinux.
>
> Are you trying to load R5 firmware written in C++ from linux kernel?
> Or R5 firmware for one core in C++ is getting loaded from another R5 core in split mode?
>
>>
>> Maybe there is someone how can help me out....
>>
>> We are working with the petalinux 2021.2 release.
>>
>> I've tested the new 2024.1 release, but there are no changes to the
>> issue.
>>
>> The c++ prog. doesnot load.
>>
>> I've searched the openAMP github for such issues, and I found this one:
>>
>> https://github.com/OpenAMP/open-amp/issues/27
>>
>> which has been closed in 2018.
>>
>> My question is now: How to get these things in the xilinx branch, or is
>> there a branch which has been fixed this issue?
>
> "these things" could you please explain specifics?
>
> Xilinx's Petalinux releases usually rely on upstream OpenAMP and Libmetal library releases.
> As of now once changes are merged in upstream OpenAMP and Libmetal libraries,
> they are picked up in .1 release cycle of Petalinux.
>
>>
>> Thank you in advance.
>>
>> BR Andreas
>>
>>
>
>
__________________________________________________________________
Von: Tanmay Shah <tanmay.shah(a)amd.com>
Gesendet: Donnerstag, 6. Juni 2024 17:44
An: Andreas Pankoke <APankoke(a)comprion.com>
Betreff: Re: AW: [Openamp-rp] c++ in xlinx linux
Hello,
On 6/6/24 10:24 AM, Andreas Pankoke wrote:
> Hello,
> thanks for your reply.
>
> Are you trying to load R5 firmware written in C++ from Linux kernel?
> Or R5 firmware for one core in C++ is getting loaded from another R5
core in split mode?
>
> No. Iam loading the R5 Program via OpenAMP from the Linux Kernel in
R5_0 like this. The R5 should be running in split-Mode. This is
configured via the Device-tree:
>
> echo CLWaveNFC_Test02.elf >
/sys/class/remoteproc/remoteproc0/firmware
> echo start > state
>
If you are executing these steps, then OpenAMP loader isn't used at all
if I understand correctly.
Instead it's elf loader in linux kernel.
Here:
[1]https://github.com/torvalds/linux/blob/v6.10-rc2/drivers/remoteproc/
remoteproc_elf_loader.c
As of now, on Xilinx platform C++ loading isn't tested.
Thanks.
Yes this one is failing I think.
BR
Andreas
> The Program has been written in C++.
>
> "these things" could you please explain specifics?
>
> Were working on the Xilinx branch.
> I mean the fix in the OpenAMP branch regarding the fix:
> #27
> [2]https://github.com/OpenAMP/open-amp/issues/27
>
> I would like to know, if it is possible to get this, c++ loading,
running on the Xilinx side.
>
> Xilinx's Petalinux releases usually rely on upstream OpenAMP and
Libmetal library releases.
> As of now once changes are merged in upstream OpenAMP and Libmetal
libraries,
> they are picked up in .1 release cycle of Petalinux.
>
> I get the error with every Release of petalinux I've tested (2021.2 &
2024.1)
>
> the error(s) is(are) essentially the following:
> [ 801.017356][ T1162] remoteproc remoteproc0: trace0 added: da
0x3ee00220, len 0x1000
> [ 801.027989][ T1162] remoteproc remoteproc0: bad phdr da 0x0 mem
0x19680
> [ 801.034608][ T1162] remoteproc remoteproc0: Failed to load program
segments: -22
> [ 801.047128][ T1162] remoteproc remoteproc0: Boot failed: -22
>
> BR
> Andreas
>
>
>
> ________________________________
> Von: Tanmay Shah <tanmay.shah(a)amd.com>
> Gesendet: Donnerstag, 6. Juni 2024 16:32
> An: Andreas Pankoke <APankoke(a)comprion.com>;
openamp-rp(a)lists.openampproject.org
<openamp-rp(a)lists.openampproject.org>
> Betreff: Re: [Openamp-rp] c++ in xlinx linux
>
> Hello,
>
> I would like you understand your use case first.
> Please find my questions inline.
>
>
> On 6/6/24 8:29 AM, Andreas Pankoke via Openamp-rp wrote:
>> We are COMPRION GmbH from Germany, and we are using the Xilinx
FPGA
>> ZynqMP XCZU3EG for our new testing-devices.
>>
>> I'am an embedded engineer, with the responsibillity to program
the
>> ZynqMP Linux and R5 Progs.
>>
>> Currently I've the problem, that a load of a c++ program via
remoteproc
>> doesnot work in the xilinx petalinux.
>
> Are you trying to load R5 firmware written in C++ from linux kernel?
> Or R5 firmware for one core in C++ is getting loaded from another R5
core in split mode?
>
>>
>> Maybe there is someone how can help me out....
>>
>> We are working with the petalinux 2021.2 release.
>>
>> I've tested the new 2024.1 release, but there are no changes to
the
>> issue.
>>
>> The c++ prog. doesnot load.
>>
>> I've searched the openAMP github for such issues, and I found
this one:
>>
>> [3]https://github.com/OpenAMP/open-amp/issues/27
>>
>> which has been closed in 2018.
>>
>> My question is now: How to get these things in the xilinx branch,
or is
>> there a branch which has been fixed this issue?
>
> "these things" could you please explain specifics?
>
> Xilinx's Petalinux releases usually rely on upstream OpenAMP and
Libmetal library releases.
> As of now once changes are merged in upstream OpenAMP and Libmetal
libraries,
> they are picked up in .1 release cycle of Petalinux.
>
>>
>> Thank you in advance.
>>
>> BR Andreas
>>
>>
>
>
References
1. https://github.com/torvalds/linux/blob/v6.10-rc2/drivers/remoteproc/remotep…
2. https://github.com/OpenAMP/open-amp/issues/27
3. https://github.com/OpenAMP/open-amp/issues/27
We are COMPRION GmbH from Germany, and we are using the Xilinx FPGA ZynqMP XCZU3EG for our new testing-devices.
I'am an embedded engineer, with the responsibillity to program the ZynqMP Linux and R5 Progs.
Currently I've the problem, that a load of a c++ program via remoteproc doesnot work in the xilinx petalinux.
Maybe there is someone how can help me out....
We are working with the petalinux 2021.2 release.
I've tested the new 2024.1 release, but there are no changes to the issue.
The c++ prog. doesnot load.
I've searched the openAMP github for such issues, and I found this one:
https://github.com/OpenAMP/open-amp/issues/27
which has been closed in 2018.
My question is now: How to get these things in the xilinx branch, or is there a branch which has been fixed this issue?
Thank you in advance.
BR Andreas
We are COMPRION GmbH from Germany, and we are using the Xilinx FPGA
ZynqMP XCZU3EG for our new testing-devices.
I'am an embedded engineer, with the responsibillity to program the
ZynqMP Linux and R5 Progs.
Currently I've the problem, that a load of a c++ program via remoteproc
doesnot work in the xilinx petalinux.
Maybe there is someone how can help me out....
We are working with the petalinux 2021.2 release.
I've tested the new 2024.1 release, but there are no changes to the
issue.
The c++ prog. doesnot load.
I've searched the openAMP github for such issues, and I found this one:
https://github.com/OpenAMP/open-amp/issues/27
which has been closed in 2018.
My question is now: How to get these things in the xilinx branch, or is
there a branch which has been fixed this issue?
Thank you in advance.
BR Andreas
Branch: refs/heads/main
Home: https://github.com/OpenAMP/open-amp
Commit: e9eef7ce57c361eec7b4006c537d26ced0e02aec
https://github.com/OpenAMP/open-amp/commit/e9eef7ce57c361eec7b4006c537d26ce…
Author: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Date: 2024-05-31 (Fri, 31 May 2024)
Changed paths:
M VERSION
Log Message:
-----------
release: open-amp 2024.05.0
Set library version to 1.6.0
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Signed-off-by: Ed Mooring <ed.mooring(a)gmail.com>
Signed-off-by: Tanmay Shah <tanmay.shah(a)amd.com>
To unsubscribe from these emails, change your notification settings at https://github.com/OpenAMP/open-amp/settings/notifications
Branch: refs/heads/main
Home: https://github.com/OpenAMP/libmetal
Commit: 3aee6be866b190d2e2b4997fedbd976a0c37c0c6
https://github.com/OpenAMP/libmetal/commit/3aee6be866b190d2e2b4997fedbd976a…
Author: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Date: 2024-05-31 (Fri, 31 May 2024)
Changed paths:
M VERSION
Log Message:
-----------
release: libmetal 2024.05.0
Set library version to 1.6.0
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Signed-off-by: Ed Mooring <ed.mooring(a)gmail.com>
Signed-off-by: Tanmay Shah <tanmay.shah(a)amd.com>
To unsubscribe from these emails, change your notification settings at https://github.com/OpenAMP/libmetal/settings/notifications
Branch: refs/heads/v2024.05-rc
Home: https://github.com/OpenAMP/open-amp
Commit: 0538be5c9433d761e1479d554936d820476934e5
https://github.com/OpenAMP/open-amp/commit/0538be5c9433d761e1479d554936d820…
Author: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Date: 2024-05-22 (Wed, 22 May 2024)
Changed paths:
M lib/include/openamp/virtio.h
Log Message:
-----------
lib: fix build error using legacy VIRTIO_DEVICE/DRIVER_ONLY
As part of the deprecation process for VIRTIO_DEVICE_ONLY and
VIRTIO_DRIVER_ONLY, we should still support builds without errors when
possible.
For legacy support, define VIRTIO_DRIVER_SUPPORT and VIRTIO_DEVICE_SUPPORT
default values based on VIRTIO_DEVICE_ONLY and VIRTIO_DRIVER_ONLY.
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
To unsubscribe from these emails, change your notification settings at https://github.com/OpenAMP/open-amp/settings/notifications
Branch: refs/heads/main
Home: https://github.com/OpenAMP/open-amp
Commit: 0538be5c9433d761e1479d554936d820476934e5
https://github.com/OpenAMP/open-amp/commit/0538be5c9433d761e1479d554936d820…
Author: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Date: 2024-05-22 (Wed, 22 May 2024)
Changed paths:
M lib/include/openamp/virtio.h
Log Message:
-----------
lib: fix build error using legacy VIRTIO_DEVICE/DRIVER_ONLY
As part of the deprecation process for VIRTIO_DEVICE_ONLY and
VIRTIO_DRIVER_ONLY, we should still support builds without errors when
possible.
For legacy support, define VIRTIO_DRIVER_SUPPORT and VIRTIO_DEVICE_SUPPORT
default values based on VIRTIO_DEVICE_ONLY and VIRTIO_DRIVER_ONLY.
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
To unsubscribe from these emails, change your notification settings at https://github.com/OpenAMP/open-amp/settings/notifications
Branch: refs/heads/main
Home: https://github.com/OpenAMP/open-amp
Commit: 31fb9138bc2ba6c408936f3270341dbfd99bdb14
https://github.com/OpenAMP/open-amp/commit/31fb9138bc2ba6c408936f3270341dbf…
Author: Andrew Davis <afd(a)ti.com>
Date: 2024-05-20 (Mon, 20 May 2024)
Changed paths:
M lib/include/openamp/rpmsg_virtio.h
Log Message:
-----------
rpmsg_virtio: Fix return value comment for rpmsg_virtio_get_role()
The `role` member of `struct virtio_device` stores either the value
VIRTIO_DEV_DRIVER or VIRTIO_DEV_DEVICE. This means the function
rpmsg_virtio_get_role() will also return one of these values.
The values RPMSG_HOST and RPMSG_REMOTE are defined to be the same,
but there is no need for this redefinition. Update the return
values in the comment docs.
While here, remove the same from rpmsg_virtio_set_wait_cb() which
does not return anything, this looks to be a copy/paste error.
Signed-off-by: Andrew Davis <afd(a)ti.com>
Commit: 5d8e63f2efe5337ca1f3a612dee9ac37e1b8d2a8
https://github.com/OpenAMP/open-amp/commit/5d8e63f2efe5337ca1f3a612dee9ac37…
Author: Andrew Davis <afd(a)ti.com>
Date: 2024-05-20 (Mon, 20 May 2024)
Changed paths:
M lib/rpmsg/rpmsg_virtio.c
Log Message:
-----------
rpmsg_virtio: Deprecate RPMSG_HOST and RPMSG_REMOTE definitions
For all cases when the role is checked in rpmsg_virtio, what is being
checked is the role of the underlying virtio layer. As such, we should
be matching against the role definitions for the virtio layer
(VIRTIO_DEV_DEVICE and VIRTIO_DEV_DRIVER). Fix this here.
While the underlying virtio layer may be asymmetric, the RPMSG layer
generally is symmetrical. There is no need to define a HOST or REMOTE
role specific to the RPMSG layer. And as there are now no more internal
users of these definitions, deprecate them here.
Signed-off-by: Andrew Davis <afd(a)ti.com>
Commit: fdef576779d676732e26b26687940965785bc1ee
https://github.com/OpenAMP/open-amp/commit/fdef576779d676732e26b26687940965…
Author: Andrew Davis <afd(a)ti.com>
Date: 2024-05-20 (Mon, 20 May 2024)
Changed paths:
M lib/rpmsg/rpmsg_virtio.c
Log Message:
-----------
rpmsg_virtio: Use VIRTIO_ROLE_IS_{DRIVER,DEVICE}() macros
Now that we match role to VIRTIO_DEV_{DRIVER,DEVICE} we can replace
all these double check if statements with the role checking macro
already used in all other files.
Signed-off-by: Andrew Davis <afd(a)ti.com>
Compare: https://github.com/OpenAMP/open-amp/compare/e03d09a3fb08...fdef576779d6
To unsubscribe from these emails, change your notification settings at https://github.com/OpenAMP/open-amp/settings/notifications
Branch: refs/heads/main
Home: https://github.com/OpenAMP/libmetal
Commit: 1de0f27d7d5e76409a25a371d94cda3cd2c1c194
https://github.com/OpenAMP/libmetal/commit/1de0f27d7d5e76409a25a371d94cda3c…
Author: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
Date: 2024-05-20 (Mon, 20 May 2024)
Changed paths:
M lib/log.h
Log Message:
-----------
lib: fix doxygen warning in log.h
fix following warning:
lib/log.h:91: warning: argument 'args...' of command @param is not found
in the argumentlist of metal_log(level, fmt, args...)
lib/log.h:98: warning: The following parameter of
metal_log(level, fmt, args...) is not documented:
parameter 'args...'
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com>
To unsubscribe from these emails, change your notification settings at https://github.com/OpenAMP/libmetal/settings/notifications
Branch: refs/heads/main
Home: https://github.com/OpenAMP/libmetal
Commit: d52e69bb7995e2875c297c4f55e472870916988c
https://github.com/OpenAMP/libmetal/commit/d52e69bb7995e2875c297c4f55e47287…
Author: Andrew Davis <afd(a)ti.com>
Date: 2024-05-20 (Mon, 20 May 2024)
Changed paths:
M lib/device.h
M lib/log.h
M lib/shmem.h
M lib/sys.h
M lib/system/freertos/cache.h
M lib/system/generic/cache.h
M lib/system/linux/sys.h
M lib/version.h
Log Message:
-----------
lib: Do not label function declarations in headers with extern
This is not needed for function declarations, they already have
implicit external linkage.
Signed-off-by: Andrew Davis <afd(a)ti.com>
To unsubscribe from these emails, change your notification settings at https://github.com/OpenAMP/libmetal/settings/notifications